Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return if nil pointer in dag.go. Fixes #10401 #10402

Merged
merged 3 commits into from
Feb 6, 2023
Merged

fix: return if nil pointer in dag.go. Fixes #10401 #10402

merged 3 commits into from
Feb 6, 2023

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Jan 27, 2023 •
edited
Loading

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

Fixes #10401

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@isubasinghe
fix: return if nil pointer in dag.go
b5bace3 
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe isubasinghe changed the title fix: return if nil pointer in dag.go fix: return if nil pointer in dag.go. Fixes #10401 Jan 27, 2023
@isubasinghe isubasinghe marked this pull request as ready for review January 27, 2023 00:48
sarabala1979
sarabala1979 reviewed Jan 30, 2023
View reviewed changes
workflow/controller/dag.go Outdated
@@ -382,6 +382,8 @@ func (woc *wfOperationCtx) executeDAGTask(ctx context.Context, dagCtx *dagContex
scope, err := woc.buildLocalScopeFromTask(dagCtx, task)
if err != nil {
woc.markNodeError(node.Name, err)
woc.log.Errorf("Got a nil pointer for scope due to error %s", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isubasinghe Can you reword the message? "Failed to build local scope from task" and add task name as field

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarabala1979 done

@isubasinghe
fix: added field to logging
7202998 
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@sarabala1979 sarabala1979 merged commit dc30da8 into argoproj:master Feb 6, 2023
isubasinghe added a commit to isubasinghe/argo-workflows that referenced this pull request Feb 9, 2023
@isubasinghe
fix: return if nil pointer in dag.go. Fixes argoproj#10401 (argoproj#…
3f5a305 
…10402)

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
GoshaDo pushed a commit to GoshaDo/argo-workflows that referenced this pull request Feb 9, 2023
@isubasinghe @GoshaDo
fix: return if nil pointer in dag.go. Fixes argoproj#10401 (argoproj#…
51ab79a 
…10402)

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: goshado <goshatoo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled nil pointer in dag.go
2 participants
@isubasinghe @sarabala1979