Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go to 1.20 in devcontainer #11115

Merged
merged 1 commit into from
May 21, 2023

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented May 21, 2023

Motivation

Commit a5581f8 updated golang required to build in go.mod to 1.20.

This makes the devcontainer compatible

Modifications

Update the version of golang to 1.20 in the devcontainer specification

Verification

Smoke test that I can now run make using this container, as opposed to it failing immediately.

Signed-off-by: Alan Clucas <alan@clucas.org>
@terrytangyuan terrytangyuan marked this pull request as ready for review May 21, 2023 20:58
@terrytangyuan terrytangyuan merged commit 2a5c4e8 into argoproj:master May 21, 2023
@Joibel Joibel deleted the go120devcontainer branch May 28, 2023 18:24
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants