Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value and type -> $value and $type causes issues in current version of figma-tokens #455

Closed
hchiam opened this issue Dec 28, 2023 · 0 comments · Fixed by #456
Closed

value and type -> $value and $type causes issues in current version of figma-tokens #455

hchiam opened this issue Dec 28, 2023 · 0 comments · Fixed by #456

Comments

@hchiam
Copy link
Contributor

hchiam commented Dec 28, 2023

while updating my notes and videos of setting up op in figma-tokens, i noticed tokens aren't properly generated in the latest figma-tokens plugin when i try to use either of the following URLs:

Commit 327a70f was done to update design token json to the latest spec syntax, but i'm thinking we'll need to undo part of the commit to treat figma tokens differently.

it seems the figma-tokens plugin is still expecting value and type instead of $value and $type because it keeps trying to recreate value and type when i hit "Save JSON", but it does so badly:

figma-tokens tries to convert from $value to value but does it badly

and the output does not look right:

the output has $value and $type as individual values, with everything under Other
hchiam added a commit to hchiam/open-props that referenced this issue Dec 28, 2023
argyleink pushed a commit that referenced this issue Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant