use srcObject in setSinkId (katspaugh#1429)

* use srcObject in setSinkId to replace deprecated API * update changelog
armedoctopus · Aug 19, 2018 · e99d724 · e99d724
1 parent a497c33
commit e99d724
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,13 @@
 wavesurfer.js changelog
 =======================
 
+2.0.7 (unreleased)
+------------------
+
+- Add wavesurfer.js logo, created by @entonbiba (#1409)
+- Fix `setSinkId` that used deprecated API (#1428)
+- Set `isReady` attribute to false when emptying wavesufer (#1396, #1403)
+
 2.0.6 (14.06.2018)
 ------------------
 

diff --git a/src/webaudio.js b/src/webaudio.js
@@ -286,7 +286,7 @@ export default class WebAudio extends util.Observer {
     setSinkId(deviceId) {
         if (deviceId) {
             /**
-             * The webaudio api doesn't currently support setting the device
+             * The webaudio API doesn't currently support setting the device
              * output. Here we create an HTMLAudioElement, connect the
              * webaudio stream to that element and setSinkId there.
              */
@@ -300,7 +300,7 @@ export default class WebAudio extends util.Observer {
             var dest = this.ac.createMediaStreamDestination();
             this.gainNode.disconnect();
             this.gainNode.connect(dest);
-            audio.src = URL.createObjectURL(dest.stream);
+            audio.srcObject = dest.stream;
 
             return audio.setSinkId(deviceId);
         } else {