Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand locale timeframe testing for multiple variations #1073

Merged
merged 6 commits into from
Dec 12, 2021

Conversation

neelrpatel
Copy link
Contributor

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Resolves #1022

Timeframe testing for multiple variations expanded for the following locales:

  • Finnish
  • Czech
  • Hungarian
  • Hebrew
  • Sinhala
  • Croatian
  • Serbian
  • Zulu

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #1073 (50ae019) into master (d688de4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1073   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2232      2232           
  Branches       437       437           
=========================================
  Hits          2232      2232           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d688de4...50ae019. Read the comment docs.

@krisfremen
Copy link
Member

@neelrpatel thanks for contributing!

Approved the checks to run, will review soon

Copy link
Member

@anishnya anishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anishnya anishnya merged commit be57df5 into arrow-py:master Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More Detailed Test Cases For Locales
3 participants