Separate replace & shift function #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to PR Request from issue arrow-py#220
Replace w/shift function will be removed in next release hopefully
…d sipp11:shift Conflicts: arrow/arrow.py tests/arrow_tests.py
added 4 commits
August 23, 2016 11:24
…`quarters` argument
Current coverage is 100% (diff: 100%)@@ master #349 diff @@
====================================
Files 8 8
Lines 1244 1253 +9
Methods 0 0
Messages 0 0
Branches 193 193
====================================
+ Hits 1244 1253 +9
Misses 0 0
Partials 0 0
|
|
I'll get this merged in tonight. |
samdroid-apps
added a commit
to samdroid-apps/arrow
that referenced
this pull request
Jan 4, 2017
Commit 15d903a (from arrow-py#349), separated the replace and shift features into two functions. However the docs still show the old, deprecated and more confusing use of replace to shift the time.
andrewelkins
pushed a commit
that referenced
this pull request
Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the merge conflicts from #276. It also fixes (in b5eee6d) a bug in the
quartersfunctionality, addsquarterstoshift, and gets back to 100% code coverage.Separating replace and shift functionality would save a lot of headaches!