Fix negative offset for UTC #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying ZZ in a format string gives an offest of -00:00 for UTC, despite the arrow object repr showing +00:00. Detect `using >= 0` for consistency.
|
Cheers for looking at this |
|
Hmmm, the tests failed because of the format change. I guess either they want it to be like that, or they're locking in the behaviour for some other reason. I'll fix the tests, but there's no guarantee that the maintainers will appreciate the patch! 😄 |
Current coverage is 100% (diff: 100%)@@ master #377 diff @@
====================================
Files 14 14
Lines 2899 2902 +3
Methods 0 0
Messages 0 0
Branches 207 208 +1
====================================
+ Hits 2899 2902 +3
Misses 0 0
Partials 0 0
|
|
I'll merge. This goes against what moment.js does and just is odd behavior. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying ZZ in a format string gives an offest of -00:00 for UTC,
despite the arrow object repr showing +00:00. Detect
using >= 0for consistency.