Humanizegranularity #388
Merged
Humanizegranularity #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow don't supports week granularity
Current coverage is 100% (diff: 100%)@@ master #388 diff @@
====================================
Files 14 14
Lines 2944 3011 +67
Methods 0 0
Messages 0 0
Branches 215 224 +9
====================================
+ Hits 2944 3011 +67
Misses 0 0
Partials 0 0
|
| ''' Returns a localized, humanized representation of a relative difference in time. | ||
|
|
||
| :param other: (optional) an :class:`Arrow <arrow.arrow.Arrow>` or ``datetime`` object. | ||
| Defaults to now in the current :class:`Arrow <arrow.arrow.Arrow>` object's timezone. | ||
| :param locale: (optional) a ``str`` specifying a locale. Defaults to 'en_us'. | ||
| :param only_distance: (optional) returns only time difference eg: "11 seconds" without "in" or "ago" part. | ||
|
|
||
| :param granularity: (optinal) defines the precision of the output. Set it to strings 'second', 'minute', 'hour', 'day', 'month' or 'year'. |
There was a problem hiding this comment.
typo: optinal
Also, it'd be good if you could include some usage examples in the PR comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature allowing to select the granularity of the humanize function. We can receive for example 65 minutes ago rather than 1 hour ago.