Added more human-readable error message for invalid frames for range/span #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but can you fix it so it passes all tests? https://travis-ci.org/crsmithdev/arrow/jobs/189177908 |
|
Yup, gotcha! |
Current coverage is 100% (diff: 100%)@@ master #407 diff @@
====================================
Files 14 14
Lines 3082 3081 -1
Methods 0 0
Messages 0 0
Branches 226 226
====================================
- Hits 3082 3081 -1
Misses 0 0
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty minor change, I just goofed it up and was a bit confounded by the non-descriptive error message. This should make it clearer what happened.