Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Estonian localisation #518

Merged
merged 8 commits into from
Mar 9, 2018
Merged

Added Estonian localisation #518

merged 8 commits into from
Mar 9, 2018

Conversation

zcribe
Copy link
Contributor

@zcribe zcribe commented Feb 21, 2018

Adapted version of hungarian locale.

@Syeberman
Copy link
Contributor

@zcribe, thanks for the patch! The build is currently failing as there's some untested code in your submission. Can you add a few more tests that target _format_timeframe?

@zcribe
Copy link
Contributor Author

zcribe commented Feb 26, 2018

I do not actually understand what additional tests it wants me to write. Any insight into this would be greatly appreciated.

@Syeberman
Copy link
Contributor

I believe, since all your timeframes are dicts, you just need to remove the if isinstance(form,dict): line. Code coverage is likely telling you that the isinstance check is unnecessary.

@codecov-io
Copy link

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #518   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        3230   3288   +58     
  Branches      231    232    +1     
=====================================
+ Hits         3230   3288   +58
Impacted Files Coverage Δ
arrow/locales.py 100% <100%> (ø) ⬆️
tests/locales_tests.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95077b...73ce2aa. Read the comment docs.

@Syeberman Syeberman merged commit c87c768 into arrow-py:master Mar 9, 2018
@Syeberman
Copy link
Contributor

Thanks again, @zcribe!

@zcribe zcribe deleted the patch-1 branch April 5, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants