Handle date with over 999999 microseconds #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 1531 1537 +6
Branches 233 234 +1
=====================================
+ Hits 1531 1537 +6
Continue to review full report at Codecov.
|
jadchaar
requested changes
Aug 19, 2019
There was a problem hiding this comment.
Thanks for the contribution @matthewdooler! The fix is solid, but I had a few suggestions regarding comments and tests.
|
@jadchaar thanks for the suggestions, does this look good now? |
|
Looks great now! Since this is a sensitive change, I wanna pass it by @systemcatch as well before merging it in. |
jadchaar
approved these changes
Aug 19, 2019
systemcatch
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636