Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weeks and expand on tests for Tagalog locale #849

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

krisfremen
Copy link
Member

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

This adds weeks and meridians to Tagalog.
Along with a full battery of tests.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #849 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #849   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1785      1786    +1     
  Branches       307       307           
=========================================
+ Hits          1785      1786    +1     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba103db...f9c4bff. Read the comment docs.

@systemcatch systemcatch changed the title Add weeks and expand on tests for Tagalog. Add weeks and expand on tests for Tagalog locale Sep 10, 2020
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the translations but I'm loving the extensive tests!

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Like Chris said, nice test additions.

@jadchaar jadchaar merged commit 80aa80c into master Sep 10, 2020
@jadchaar jadchaar deleted the add_weeks_tagalog branch September 10, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants