Update TurkishLocale

[beucismis]

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

• 🧪 Added tests for changed code.
• 🛠️ All tests pass when run locally (run tox or make test to find out!).
• 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
• 📚 Updated documentation for changed code.
• ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Update TurkishLocale class. Added and_word, week, weeks and meridians.
Edit: Add TestTurkishLocale class in tests/test_test_locales.py.

[beucismis]

If you give me some time I can add the TestTurkishLocale class. What other test class can I get a template from?

[krisfremen]

If you give me some time I can add the TestTurkishLocale class. What other test class can I get a template from?

Sure, take your time.

Take a look at the Macedonian or Tagalog locale for a more comprehensive test suite.

Cheers

[beucismis]

Cheers, thank you. I added TestTurkishLocale class.

[beucismis]

Hi, Some localizations have problems. I am trying to understand.
For example, "week" is output instead of "1 week".

[anishnya]

Hi, Some localizations have problems. I am trying to understand.
For example, "week" is output instead of "1 week".

@beucismis could you provide the list of locales where you've noticed this? Typically, we would like humanize to represent the time difference of 1 week as "a week", not "week" across locales (same applies to the units 1 second, 1 month etc ). I'm not too sure if this possible to achieve in certain locales, but the goal is to be as close as possible to a rough translation of "a week".

From experience with dehumanize, there are some locales that need work on this issue. @krisfremen @jadchaar, we might want to open this up to be a separate issue and have an open list of locales with issues.

[krisfremen]

@anishnya agreed, we should open up issues and tackle them separately

[beucismis]

@beucismis could you provide the list of locales where you've noticed this?

>>> past = arrow.utcnow().shift(weeks=-1)
>>> past.humanize(locale="tr")
'hafta önce'

False. It should be "1 hafta önce" or "bir hafta önce". The English translation of "hafta önce" is "week ago".

[beucismis]

I write "bir hafta" instead of "hafta"?

"hafta": "week"
"bir hafta": "a week"

[anishnya]

"bir hafta" would be what we want.

[beucismis]

Test results successful.

[codecov]

Codecov Report

Merging #982 (29c1e54) into master (119bb67) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #982   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2054      2056    +2     
  Branches       330       330           
=========================================
+ Hits          2054      2056    +2     

Impacted Files	Coverage Δ
arrow/locales.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119bb67...29c1e54. Read the comment docs.

[anishnya]

Hey @beucismis. There are some extremely minor linting errors that need to be fixed. It is mainly just an issue with some of the longer assert statements within the test cases. See the output on the linter checks for more specifics. Other than that, everything else looks good to pull in. Let us know if you have any further questions, and we appreciate your contribution!

[anishnya]

Thanks for the contribution @beucismis!

[beucismis]

@anishnya thanks.