Merge pull request beetbox#4433 from vicholp/master

Fix get item file in web plugin

beetsplug/web/__init__.py

@@ -324,7 +324,7 @@ def item_file(item_id):
     response = flask.send_file(
         item_path,
         as_attachment=True,
-        attachment_filename=safe_filename
+        download_name=safe_filename
     )
     response.headers['Content-Length'] = os.path.getsize(item_path)
     return response

docs/changelog.rst

@@ -92,6 +92,7 @@ Bug fixes:
   that casues a crash when ImportAdded plugin enabled.
   :bug:`4389`
 * :doc:`plugins/convert`: Fix a bug with the `wma` format alias.
+* :doc:`/plugins/web`: Fix get file from item.
 
 For packagers:
 

test/test_web.py

@@ -667,6 +667,16 @@ def test_patch_item_id_readonly(self):
         # Remove the item
         self.lib.get_item(item_id).remove()
 
+    def test_get_item_file(self):
+        ipath = os.path.join(self.temp_dir, b'testfile2.mp3')
+        shutil.copy(os.path.join(_common.RSRC, b'full.mp3'), ipath)
+        self.assertTrue(os.path.exists(ipath))
+        item_id = self.lib.add(Item.from_path(ipath))
+
+        response = self.client.get('/item/' + str(item_id) + '/file')
+
+        self.assertEqual(response.status_code, 200)
+
 
 def suite():
     return unittest.TestLoader().loadTestsFromName(__name__)