New setting ETHEREUM_LOGS_FILTER_AVAILABLE to use filters #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous design was storing two independent lists that might allow incorrect combinations: Monitoring (address1, topic1), (address2, topic2) And the previous code will process events with (address1, topic2) Now I store monitored_events as a dict with key (address, topic). Also removes the mixed between class and instance attributes in the Decoder object. Also, I add Django 3.1 to the tox suite. Still getting an error with 3.2, need to analyze...
Instead of fetching every block and transaction, if ETHEREUM_LOGS_FILTER_AVAILABLE = True uses log filters to fetch the logs.
artemistomaras
approved these changes
Mar 31, 2022
|
@gnarvaja I just published version 4.2.0 with your changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was iterating through all the TX and blocks. If
web3.eth.filterit's available, we can do much faster filtering the blocks and TX that contain specific events.Also fixes the potential error of two lists of addresses, topics when it should be a list of pairs.