Skip to content

Commit

Permalink
Add api.batch.fs.FileSystem to Sensors.
Browse files Browse the repository at this point in the history
  • Loading branch information
arthepsy committed Oct 17, 2014
1 parent 7bced27 commit 4240ef7
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
package org.sonar.plugins.scala.sensor;

import org.sonar.api.batch.Sensor;
import org.sonar.api.batch.fs.FileSystem;
import org.sonar.api.resources.Project;
import org.sonar.plugins.scala.language.Scala;

Expand All @@ -32,8 +33,10 @@
public abstract class AbstractScalaSensor implements Sensor {

private final Scala scala;
protected final FileSystem fileSystem;

protected AbstractScalaSensor(Scala scala) {
protected AbstractScalaSensor(FileSystem fileSystem, Scala scala) {
this.fileSystem = fileSystem;
this.scala = scala;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.sonar.api.batch.SensorContext;
import org.sonar.api.batch.fs.FileSystem;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.resources.InputFile;
import org.sonar.api.resources.Project;
Expand Down Expand Up @@ -58,8 +59,8 @@ public class BaseMetricsSensor extends AbstractScalaSensor {

private static final Logger LOGGER = LoggerFactory.getLogger(BaseMetricsSensor.class);

public BaseMetricsSensor(Scala scala) {
super(scala);
public BaseMetricsSensor(FileSystem fileSystem, Scala scala) {
super(fileSystem, scala);
}

public void analyse(Project project, SensorContext sensorContext) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.sonar.api.batch.Phase;
import org.sonar.api.batch.Phase.Name;
import org.sonar.api.batch.SensorContext;
import org.sonar.api.batch.fs.FileSystem;
import org.sonar.api.resources.InputFile;
import org.sonar.api.resources.Project;
import org.sonar.api.resources.ProjectFileSystem;
Expand All @@ -44,8 +45,8 @@ public class ScalaSourceImporterSensor extends AbstractScalaSensor {

private static final Logger LOGGER = LoggerFactory.getLogger(ScalaSourceImporterSensor.class);

public ScalaSourceImporterSensor(Scala scala) {
super(scala);
public ScalaSourceImporterSensor(FileSystem fileSystem, Scala scala) {
super(fileSystem, scala);
}

public void analyse(Project project, SensorContext sensorContext) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.junit.Before;
import org.junit.Test;
import org.sonar.api.batch.SensorContext;
import org.sonar.api.batch.fs.FileSystem;
import org.sonar.api.resources.Project;
import org.sonar.plugins.java.Java;
import org.sonar.plugins.scala.language.Scala;
Expand All @@ -39,7 +40,7 @@ public class AbstractScalaSensorTest {

@Before
public void setUp() {
abstractScalaSensor = new AbstractScalaSensor(Scala.INSTANCE) {
abstractScalaSensor = new AbstractScalaSensor(mock(FileSystem.class), Scala.INSTANCE) {

public void analyse(Project project, SensorContext context) {
// dummy implementation, never called in this test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.junit.Before;
import org.junit.Test;
import org.sonar.api.batch.SensorContext;
import org.sonar.api.batch.fs.FileSystem;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Measure;
import org.sonar.api.measures.Metric;
Expand All @@ -54,7 +55,7 @@ public class BaseMetricsSensorTest {

@Before
public void setUp() {
baseMetricsSensor = new BaseMetricsSensor(Scala.INSTANCE);
baseMetricsSensor = new BaseMetricsSensor(mock(FileSystem.class), Scala.INSTANCE);

fileSystem = mock(ProjectFileSystem.class);
when(fileSystem.getSourceCharset()).thenReturn(Charset.defaultCharset());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.junit.Test;
import org.mockito.InOrder;
import org.sonar.api.batch.SensorContext;
import org.sonar.api.batch.fs.FileSystem;
import org.sonar.api.resources.InputFile;
import org.sonar.api.resources.InputFileUtils;
import org.sonar.api.resources.Project;
Expand Down Expand Up @@ -51,7 +52,7 @@ public class ScalaSourceImporterSensorTest {

@Before
public void setUp() {
scalaSourceImporter = new ScalaSourceImporterSensor(Scala.INSTANCE);
scalaSourceImporter = new ScalaSourceImporterSensor(mock(FileSystem.class), Scala.INSTANCE);

fileSystem = mock(ProjectFileSystem.class);
when(fileSystem.getSourceCharset()).thenReturn(Charset.defaultCharset());
Expand Down

0 comments on commit 4240ef7

Please sign in to comment.