Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering: Empty whitespace column on sidebar column placement #382

Closed
Neved4 opened this issue Jun 11, 2020 · 2 comments
Closed

Rendering: Empty whitespace column on sidebar column placement #382

Neved4 opened this issue Jun 11, 2020 · 2 comments
Labels
🐞 bug

Comments

@Neved4
Copy link

Neved4 commented Jun 11, 2020

Affects Asciidoctor.js Live Preview 2.6.0.1 for both local and remote files in all web browsers.

Description

When using left or right as values of the :toc: attribute, an empty column is rendered for the table of contents even if there are no sections within the document. This behavior differs from both 2.5.0 and Asciidoctor 2.0.10.

Steps to reproduce

  1. Try to preview a file without sections such as the below one.
= Document Title
:toc: left

Document Body.

Related

#380

Attachments

empty-toc
@Neved4 Neved4 mentioned this issue Jun 11, 2020
Closed
18 tasks
ggrossetie added a commit to ggrossetie/asciidoctor-chrome-extension that referenced this issue Jun 12, 2020
@ggrossetie
🐛 resolves asciidoctor#382 do not add the toc2 class if the document …
663e29b 
…has no section
@ggrossetie
Copy link
Member

Good catch 👍

@Neved4
Copy link
Author

Neved4 commented Jun 12, 2020 •
edited
Loading

Thank you for the fix 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggrossetie @Neved4