-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip Auto Reshim Support #136
Pip Auto Reshim Support #136
Conversation
Hi! I came here after reading multiple issues on I'd like to see this feature merged into the I was wondering if we want to apply the same logic for |
@danhper thoughts? |
Hey, sorry for the delay! |
This will allow us to be smarter about _when to reshim_. With this update, it will be handled automatically by `asdf` and we won't require a custom chunk of code in our application: https://github.com/readthedocs/readthedocs.org/blob/a5965129c61b9bcdff2f2098ff7ce7f8c093dc74/readthedocs/doc_builder/director.py#L373-L386 Currently, multi-lines commands that install something with `pip` and immediate after that, inside the multi-line command try to use the executable installed, fail because it's not automatically reshimed. By reshiming at `asdf` level, this case will be solved. Related: readthedocs/readthedocs.org#9150 (comment) Related: asdf-community/asdf-python#136
* asdf: update `asdf` and all its plugins This will allow us to be smarter about _when to reshim_. With this update, it will be handled automatically by `asdf` and we won't require a custom chunk of code in our application: https://github.com/readthedocs/readthedocs.org/blob/a5965129c61b9bcdff2f2098ff7ce7f8c093dc74/readthedocs/doc_builder/director.py#L373-L386 Currently, multi-lines commands that install something with `pip` and immediate after that, inside the multi-line command try to use the executable installed, fail because it's not automatically reshimed. By reshiming at `asdf` level, this case will be solved. Related: readthedocs/readthedocs.org#9150 (comment) Related: asdf-community/asdf-python#136 * Docs: update readme to mention `ubuntu-22.04` and `buildx` * Tests: update version to check
Solves #37. Inspired by the npm version.