Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more pre-commit checks #1195

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add some more pre-commit checks #1195

merged 2 commits into from
Sep 20, 2022

Conversation

WilliamJamieson
Copy link
Contributor

No description provided.

zacharyburnett
zacharyburnett approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the pre-commit checks don't take long

@WilliamJamieson
Copy link
Contributor Author

LGTM, assuming the pre-commit checks don't take long

These are all basically grep/regex checks. So they are basically instant. flake8 is so slow that you don't even notice them

@WilliamJamieson WilliamJamieson merged commit bf80c46 into asdf-format:master Sep 20, 2022
@WilliamJamieson WilliamJamieson deleted the pre-commit/simple-checks branch September 20, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamJamieson @zacharyburnett