-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry::new returns Err when entry point isn't found #390
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1959612
Check for entry point in EntryCustom::new and return error
Rua 215f53b
Split off into load_checked
Rua a657cd7
Merge branch 'master' into staticfn-result
Rua 3bee8af
Merge branch 'master' into staticfn-result
Rua ad22866
Merge branch 'master' of https://github.com/MaikKlein/ash into static…
Rua d76725b
Remove string from MissingEntryPoint
Rua b0e2031
Change MissingEntryPoint error message
Rua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 years later I'm rather curious why I didn't notice the TODO (and
static
vsconst
), as theENTRY_POINT
string literal could be inlined in theCStr::from_bytes_with_nul_unchecked()
call as I had done myself in #379 just a week before this PR was opened 😬At this point I'm assuming it doesn't matter whether to assign to a
let
binding or change this toconst
(will be more verbose with forcedconst CNAME: &CStr
type), as the function call is hopefully inlined either way? (this does matter for public symbols though, but that's a different beast)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect all of the above to compile down the same, yeah. Might as well favor clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ralith What would you consider more clear for these one-off inline named bindings,
const
orlet
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best practice to favor
let
when it's applicable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I can't imagine the compiler treating a fully-
const
path any different no matter whether it's via alet
binding, inlined completely, or assigned to aconst
.