Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VK_NN_vi_surface extension #398

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Mar 14, 2021

I followed the examples of other surface extensions for this one, so hopefully it's good as-is. I was not sure whether the function names should have _nn at the end or not. create_xlib_surface doesn't end in _khr but create_mac_os_surface_mvk does have the _mvk. My own preference would be without the suffix, since it's already implicit in the module and struct name.

Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure whether the function names should have _nn at the end or not. create_xlib_surface doesn't end in _khr but create_mac_os_surface_mvk does have the _mvk. My own preference would be without the suffix, since it's already implicit in the module and struct name.

Fully agree; perhaps a followup patch should remove it from macos_surface and ios_surface. We're allowed to version-wise, though some projects might not like us for it :D

@MaikKlein MaikKlein merged commit 3094084 into ash-rs:master Mar 20, 2021
@Rua Rua deleted the VK_NN_vi_surface branch April 30, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants