Add extended dynamic state extension #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
requested changes
Apr 25, 2021
filnet
force-pushed
the
extended_dynamic_state
branch
2 times, most recently
from
46e364c
to
747fa8b
Compare
MarijnS95
reviewed
Apr 27, 2021
filnet
force-pushed
the
extended_dynamic_state
branch
2 times, most recently
from
2422304
to
c556563
Compare
filnet
force-pushed
the
extended_dynamic_state
branch
from
c556563
to
746e540
Compare
MarijnS95
reviewed
Apr 27, 2021
| depth_test_enable: bool, | ||
| ) { | ||
| self.extended_dynamic_state_fn | ||
| .cmd_set_depth_test_enable_ext(command_buffer, depth_test_enable.into()) |
There was a problem hiding this comment.
Heh, I wasn't even aware we used .into() for bool -> Bool32 conversion (struct builders use it) but I like it, as long as this results in vk::FALSE and vk::TRUE. Perhaps we should clean up if update { vk::TRUE } else { vk::FALSE } in nv/ray_tracing.rs some time.
|
@filnet Thanks! Merged! Not sure why the commit title reads |
|
The title is wrong : it is a copy/paste from a similar title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.