Globally remove all allow(dead_code) exceptions and make extensions public #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hiding the fact that some extension functions are inadvertently not public and hence unusable by crate users, nor does it enforce clean coding practices. In addition remove `ash/src/allocator.rs` which does not appear to be used (anymore?) and isn't in a working state anyway.
|
Vulkano already uses them, so any switch to Ash would require support for them, that's all. |
|
@Rua I meant that the functions were not accessible outside of the Ash crate before this PR 😉 |
|
Oops! Well, the Vulkano conversion hasn't happened yet. Still some implementation details to consider, as well as the suggestion to use Erupt instead that someone brought up. |
MaikKlein
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow(dead_code)is hiding the fact that some extension functions are inadvertently not public and hence unusable by crate users, nor does it enforce clean coding practices.In addition remove
ash/src/allocator.rswhich does not appear to be used (anymore?) and isn't in a working state anyway.CC @Rua, I'm curious how you intended to use these extensions in vulkano :)