generator: Add missing documentation to bitflag extension variants #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Nov 23, 2021
generator/src/lib.rs
Outdated
Comment on lines
2381
to
2388
| let notation = constant.notation().map(|n| { | ||
| let lowercase = n.to_lowercase(); | ||
| if lowercase.contains("backwards") || lowercase.starts_with("alias") { | ||
| quote!(#[deprecated = #n]) | ||
| } else { | ||
| quote!(#[doc = #n]) | ||
| } | ||
| }); |
There was a problem hiding this comment.
Some duplicated code, perhaps we should move this as a default-implementation to trait ConstantExt.
There was a problem hiding this comment.
Did we ever work out what was going on with @MaikKlein's generator rewrite?
There was a problem hiding this comment.
There are no direct plans to finish it that I'm aware of. I haven't personally looked through it enough to see if I/we could continue on and finish it, nor how far along it is in the first place.
Ralith
approved these changes
Nov 23, 2021
generator/src/lib.rs
Outdated
Comment on lines
2381
to
2388
| let notation = constant.notation().map(|n| { | ||
| let lowercase = n.to_lowercase(); | ||
| if lowercase.contains("backwards") || lowercase.starts_with("alias") { | ||
| quote!(#[deprecated = #n]) | ||
| } else { | ||
| quote!(#[doc = #n]) | ||
| } | ||
| }); |
There was a problem hiding this comment.
Did we ever work out what was going on with @MaikKlein's generator rewrite?
MarijnS95
force-pushed
the
constant-doc
branch
from
c47ba20
to
d41435f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.