extensions: Don't check extension names for interior nuls at runtime #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This name is emitted by the generator and already known to not contain any null-characters: replace the runtime iteration+comparison (hidden behind `from_bytes_with_nul`) and `.expect()` panic with an `unsafe` "cast" through `from_bytes_with_nul_unchecked`, just like the function-pointer loaders.
MarijnS95
force-pushed
the
remove-runtime-string-interior-nul-check
branch
from
86a499c
to
9a6389f
Compare
Ralith
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This name is emitted by the generator and already known to not contain any null-characters: replace the runtime iteration+comparison (hidden behind
from_bytes_with_nul) and.expect()panic with anunsafe"cast" throughfrom_bytes_with_nul_unchecked, just like the function-pointer loaders.