extensions/ext: Add VK_EXT_calibrated_timestamps extension #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jan 13, 2022
MarijnS95
commented
Jan 13, 2022
|
If anyone knows why they called the function here |
This extension can be used to correlate timestamps on the GPU timeline (`vkCmdWriteTimestamp`, `vkCmdWriteTimestamp2KHR`) to the CPU timeline (ie. `CLOCK_MONOTONIC` and friends).
MarijnS95
force-pushed
the
calibrated-timestamps
branch
from
c36f6c9
to
e1596c2
Compare
|
Wouldn't be the first editorial mistake in the API; raise an issue upstream if you're sure. |
Ralith
approved these changes
Jan 14, 2022
|
https://en.wiktionary.org/wiki/calibrateable Says that it works as an alternative, so I guess no harm done 😬 |
MarijnS95
added a commit
that referenced
this pull request
Jan 24, 2022
Manual code files usually see extra documentation lines added with `///`, making for a rather unpleasant (source code) reading experience when mixed with a link wrapped in `#[doc]`. This is just a copy-paste remnant from autogenerated code (`quote` macro converts `///` to `#[doc]`) and can easily be omitted in manual code. [#556]: #556 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension can be used to correlate timestamps on the GPU timeline (
vkCmdWriteTimestamp,vkCmdWriteTimestamp2KHR) to the CPU timeline (ie.CLOCK_MONOTONICand friends).