Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vulkan-Headers to 1.3.244 #697

Merged
merged 9 commits into from
Mar 21, 2023
Merged

Update Vulkan-Headers to 1.3.244 #697

merged 9 commits into from
Mar 21, 2023

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Jan 19, 2023

Depends on #719

Closes #698, closes #670

Lots of churn to use the new api attribute, but all worth it in the end. Also notice the shiny new deprecated attribute 🎉

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.3.239 Update Vulkan-Headers to 1.3.241 Feb 16, 2023
@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.3.241 Update Vulkan-Headers to 1.3.242 Feb 26, 2023
@Lokathor
Copy link

Parts of the PR update to 1.3.241 while the title says 1.3.242. I don't know which is correct but they should be made to agree before this merges.

@MarijnS95
Copy link
Collaborator Author

MarijnS95 commented Feb 28, 2023

Don't worry about it. I sometimes forget to update the value in the changelog and Cargo.toml but end up double-checking before merging (and definitely before releasing).

In this particular case there's still lots to do on the generator side to make the new format work. What appear to be simple changes can only be passed through to the vk-parse structs, while we still partly rely on the unmaintained vkxml crate. Desire has always been to migrate to vk-parse (and lately: rewrite the generator altogether) but that has yet to materialize, to the point that forking and updating vkxml may seem more realistic 😞

@Lokathor
Copy link

Well, I mean I've got a whole new parser that works on the latest XML, but since it's totally separate data types you'd (probably?) have to adjust your output stage a lot to use it.

@MarijnS95
Copy link
Collaborator Author

It seems that everyone is writing a new parser, generator, or minimal Vulkan wrapper library nowadays, but that doesn't help us if it takes significant time to integrate with our generator/rewrite. Feel free to join in on #662 as we try to work out how (and when?) to merge Erupt's generator and approach to Vulkan with Ash.

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.3.242 Update Vulkan-Headers to 1.3.243 Mar 12, 2023
ash/src/vk/bitflags.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 force-pushed the update branch 2 times, most recently from d1c3731 to 31dca51 Compare March 13, 2023 20:22
@MarijnS95 MarijnS95 requested a review from Ralith March 13, 2023 20:50
@MarijnS95
Copy link
Collaborator Author

@Ralith can you check out #719 and this PR? Upstream CI is waiting for us to be compatible with the new vk.xml format again.

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.3.243 Update Vulkan-Headers to 1.3.244 Mar 21, 2023
@MarijnS95 MarijnS95 merged commit a9fbc71 into master Mar 21, 2023
@MarijnS95 MarijnS95 deleted the update branch March 21, 2023 06:19
MarijnS95 added a commit that referenced this pull request Apr 2, 2023
* Update Vulkan-Headers to 1.3.239

* Update Vulkan-Headers to 1.3.240

* Upgrade to `bindgen 0.63` and `vk-parse 0.9`

Updates cause no semantic changes in usage nor generated output.

* generator: Support new `deprecated` attribute

* Update Vulkan-Headers to 1.3.241

* generator: Emit `#[deprecated]` annotation for type members (struct fields)

* Update Vulkan-Headers to 1.3.242

* Update Vulkan-Headers to 1.3.243

* Update Vulkan-Headers to 1.3.244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants