Skip to content

Commit

Permalink
Added some bits on tool-data and fixed some other parts
Browse files Browse the repository at this point in the history
  • Loading branch information
Slugger70 committed Jul 21, 2018
1 parent 1ab6814 commit 1a30df7
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions docs/guide_for_reviewers.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,10 @@ This checklist is based on the IUC's [Best Practices](https://galaxy-iuc-standar
* [ ] If there is more than one tool present (tool collection), is there a `macros.xml` file?
* [ ] Is it appropriate?

**<edam_topics>**
**<edam_topics> & <edam_operations>**

* Link to the [EDAM browser](https://bioportal.bioontology.org/ontologies/EDAM?p=classes)

**<edam_operations>**

**<[parallelism]>**

**<requirements>**
Expand Down Expand Up @@ -130,6 +128,7 @@ This checklist is based on the IUC's [Best Practices](https://galaxy-iuc-standar
* [ ] Do the tests pass?
* [ ] Is the output filtering tested using the `expect_num_outputs` attribute?
* [ ] Are there unused files in `test-data/`
* [ ] In the case where the tool uses built in reference data, is there a `tool-data/tool_data_table_conf.xml.test` file?

**<help>**

Expand All @@ -141,3 +140,10 @@ This checklist is based on the IUC's [Best Practices](https://galaxy-iuc-standar

* [ ] Is there a citation
- [ ] Is it in bibtex or doi format? (doi preferred)

### Data Tables

For tools that use the built in reference data and indices:

* [ ] Is there a `tool-data/*.loc.sample` file?
* [ ] Is there a `tool-data/tool_data_table_conf.xml.sample` file?

0 comments on commit 1a30df7

Please sign in to comment.