This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
Subtract candle length from start time to calculate isPremature #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the changes, but would you mind putting them inside the ifcheck? Else they might degrade performance of the backtester. |
|
@askmike Yea I see no problem, I'll move that in. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix / feature
What is the current behavior? (You can also link to an open issue here)
Gekko wasn't starting to trade on the first live candle, it was delaying a full candle before starting trades on the live market.
What is the new behavior (if this is a feature change)?
This causes it to start trading on the first live candle.
Other information:
More info at : [GDAX] Strategy Execution Delayed or Never Starts #1689 (comment)