This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4k
Update Luno #2417
Merged
Merged
Update Luno #2417
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
16f57bf
v0.6 support for bitx (aka Luno)
hiyan bbf8c9c
v0.6 support for bitx (aka Luno)
hiyan 248a393
remove log
hiyan 5bd8595
Merge pull request #1 from askmike/develop
hiyan 734b8c0
move dependency to gb
hiyan 90fd81d
rename bitx to luno
hiyan 0d4c31f
rename bitx to luno
hiyan 4b5d09f
temp fix simultaneous advice error
hiyan 4b6846b
Merge pull request #2 from askmike/develop
hiyan a63f616
Merge pull request #3 from hiyan/develop
hiyan f576abe
Merge pull request #4 from askmike/develop
hiyan 1f29ad4
Merge pull request #5 from hiyan/develop
hiyan 81a8f5c
Merge pull request #6 from askmike/develop
hiyan 522f359
Merge pull request #7 from hiyan/develop
hiyan 06acc7d
- re-add logging
hiyan 844f271
update
hiyan 28735e0
update
hiyan abc7519
update
hiyan a5855c2
revert 4b5d09f
hiyan 67064b5
Merge pull request #8 from hiyan/gekkowk
hiyan 0b92e40
Merge pull request #9 from askmike/develop
hiyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update
- Loading branch information
commit 28735e0fb0f396d0a44e42caf36159db289ab904
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.. At that point we are sure that the order was cancelled but we do not have fill information. Let's keep it like this: we bubble up the error and have Gekko figure out how to proceed.
Assuming it was or was not partially filled will probably lead to nasty bugs down the line.