This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
export useful info in backtestResultExporter #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge v0.6.4
merge v0.6.4
check portfolio data before calculating report (askmike#2369)
- Retry insufficient balance due to server update delay - Enhanced getPorfolio - getOrder now return fees
Updated luno
export useful info in backtestResultExporter
askmike
reviewed
Sep 6, 2018
plugins/backtestResultExporter.js
Outdated
| @@ -89,6 +89,9 @@ BacktestResultExporter.prototype.processPerformanceReport = function(performance | |||
|
|
|||
| BacktestResultExporter.prototype.finalize = function(done) { | |||
| const backtest = { | |||
| watch: config.watch, | |||
There was a problem hiding this comment.
would you mind renaming this to market?
plugins/backtestResultExporter.js
Outdated
| @@ -89,6 +89,9 @@ BacktestResultExporter.prototype.processPerformanceReport = function(performance | |||
|
|
|||
| BacktestResultExporter.prototype.finalize = function(done) { | |||
| const backtest = { | |||
| watch: config.watch, | |||
| tradingAdvisor: config.tradingAdvisor, | |||
| strategy: config[config.tradingAdvisor.method], | |||
There was a problem hiding this comment.
would you mind renaming this to strategyParameters?
|
Woa, apologies for the late merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some useful config info to export file. Should help if you review your tests results at later time.