Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Fixed getFee() for binance exchange #2578

Merged
merged 5 commits into from
Oct 20, 2018
Merged

Conversation

olexiyb
Copy link
Contributor

@olexiyb olexiyb commented Oct 4, 2018

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    binance.getFee() - 0.1
    bitfinex.getFee() - 0.002

  • What is the new behavior (if this is a feature change)?
    binance.getFee() - 0.001
    bitfinex.getFee() - 0.002

  • Other information:
    Here is binance raw response. As you can see binance gives us fee as 10, when I would expect 0.1
    { makerCommission: 10,
    takerCommission: 10,
    buyerCommission: 0,
    sellerCommission: 0,
    canTrade: true,
    canWithdraw: true,
    canDeposit: true,

So we need to divide by 10000 to get decimal fee for binance

@olexiyb
Copy link
Contributor Author

olexiyb commented Oct 5, 2018

@askmike BTW why gekko does not use?

https://www.npmjs.com/package/ccxt

this library looks like implements interface to all exchanges

@askmike
Copy link
Owner

askmike commented Oct 20, 2018

nice catch, thanks!

@askmike askmike merged commit 1a5f4ae into askmike:develop Oct 20, 2018
@askmike
Copy link
Owner

askmike commented Oct 20, 2018

this library looks like implements interface to all exchanges

It's a huge library and doesn't play nice with Gekko Broker (Gekko's internal order execution library).

askmike pushed a commit that referenced this pull request Oct 23, 2018
* * fixed getFee() for binance
This was referenced Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants