Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

[DOCS] plugins.md: removed trailing comma from code example (lines 78 and 133). #2635

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

bmarchesini
Copy link
Contributor

@bmarchesini bmarchesini commented Nov 5, 2018

[DOCS] nit: removed trailing comma from code example (lines 78 and 133).

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    The example will lead to an error, "," not consistent 78 & 133

  • What is the new behavior (if this is a feature change)?
    The example will work

  • Other information:

Copy link
Owner

@askmike askmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The example will lead to an error, "," not consistent 78 & 133

It won't lead to an error, javascript ignores trailing commas. That said, it would still be good to clean this up :)

Would you mind changing the commit message to be more descriptive? Update plugins.md doesn't help us much when we look into the git history. It would be great if you can do something like:

[DOCS] nit: removed trailing comma from code example.

You don't have to create a new PR. You can use either git commit --amend or a rebase to do this (after which you should force push). In your last PR I did this manually, but can you do it this time?

@bmarchesini
Copy link
Contributor Author

bmarchesini commented Nov 6, 2018

Hi, I unfortunately created a branch for each PR and I don't understand how "rebase" or "amend" for a commit in these branches (the different patches). The documentation on the internet assumes that we are in the main branch and if I change the branch name to the patch name the commit in question does not appear. I managed to reverse what seems to be in my main branch but I can't find the concerned commits to change them :/
But I was able to change the title of my PRs to match the description required for the commits.
Have you any idea how can I do it?

@askmike
Copy link
Owner

askmike commented Nov 6, 2018 via email

"," in excess for code examples for lines 78 and 133
@bmarchesini
Copy link
Contributor Author

Hi, I think everything's fine, can you confirm that?

@askmike
Copy link
Owner

askmike commented Nov 8, 2018

Perfect! Thanks :)

@askmike askmike merged commit 5c0cf0f into askmike:develop Nov 8, 2018
This was referenced Dec 2, 2018
askmike pushed a commit that referenced this pull request Dec 2, 2018
"," in excess for code examples for lines 78 and 133
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants