Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gazelle/kotln: Fix import resolution to use ancestor packages #753

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

gazelle/kotln: Fix import resolution to use ancestor packages #753

wants to merge 2 commits into from

Commits on Oct 5, 2024

  1. Add failing deep_import test case for gazelle/kotlin. 

    When a Kotlin file imports "xyz.abc.foo.Bar.Baz", gazelle will only resolve the
import successfully if "xyz.abc.foo.Bar" can be resolved to a Bazel label.

The plugin should also check if "xyz.abc.foo", "xyz.abc", or "xyz" resolve
to a bazel label.
    @gonzojive
    gonzojive committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ff3c745 View commit details
    Browse the repository at this point in the history

  2. Fix test case. 

    TODO: update import parsing to match the Kotlin spec for 'identifier' (see
packageHeader and importHeader at
https://kotlinlang.org/spec/syntax-and-grammar.html#grammar-rule-packageHeader).
    @gonzojive
    gonzojive committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    2df8c42 View commit details
    Browse the repository at this point in the history