Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Testing #103

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Member


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

Copy link

aspect-workflows bot commented Sep 13, 2024

Test

All tests were cache hits

12 tests (100.0%) were fully cached saving 967ms.


Test

e2e/smoke

CircleCI build #77 is running...


Lint

0 issues require fixes
2 issues can be fixed automatically

💡 Auto-fix linting errors with:

bazel lint //docs:docs_delivery_only_on_change //docs:docs_delivery --fix

Gazelle

Gazelle managed files are out of date:

--- tools/lint/BUILD.bazel	1970-01-01 00:00:00.000000001 +0000
+++ tools/lint/BUILD.bazel	1970-01-01 00:00:00.000000001 +0000
@@ -0,0 +1,9 @@
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
+
+bzl_library(
+    name = "linters",
+    srcs = ["linters.bzl"],
+    visibility = ["//visibility:public"],
+    deps = ["@aspect_rules_lint//lint:shellcheck"],
+)
+

💡 Run the following to apply the suggested fixes

bazel run //:gazelle

Buildifier      Format

@gregmagolan gregmagolan force-pushed the workflows_smoke branch 2 times, most recently from 7c13468 to 592ffe3 Compare September 16, 2024 01:09
@@ -2,4 +2,5 @@

set -o errexit -o nounset -o pipefail

echo "Demostration delivery target"
msg="Demostration delivery target"
echo $msg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck provided a suggestion

Suggested change
echo $msg
echo "${msg}"

@@ -2,4 +2,5 @@

set -o errexit -o nounset -o pipefail

echo "Demostration delivery target"
msg="Demostration delivery target"
echo $msg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck provided a suggestion

Suggested change
echo $msg
echo "${msg}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant