Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-enable RBE testing #531

Merged
merged 3 commits into from
Jan 27, 2024
Merged

chore: re-enable RBE testing #531

merged 3 commits into from
Jan 27, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Jan 27, 2024 •
edited
Loading

Revert #529 with fixes

Suspicious workarounds to avoid protobuf problems: non-hermeticity with protoc->glibc and something in C++ toolchain

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jan 27, 2024 •
edited
Loading

✅ Test

All tests were cache hits

✅ Buildifier     ✅ Format

@alexeagle
Copy link
Member Author

fyi @sluongng

@alexeagle alexeagle merged commit ad0539e into main Jan 27, 2024
48 checks passed
@alexeagle alexeagle deleted the enable_rbe branch January 27, 2024 20:25
@alexeagle alexeagle mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @thesayyn