Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to latest protobuf rather than pinning #12

Merged
merged 5 commits into from
May 24, 2024
Merged

feat: default to latest protobuf rather than pinning #12

merged 5 commits into from
May 24, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented May 24, 2024

bzlmod users got v25.3 previously, which was just arbitrary at a point-in-time and is now stale.

Update the install snippet to show users how to pick a version of protoc in case they don't want to pick up new protoc when they upgrade toolchains_protoc

Also fix that rules_go was accidentally a non-dev-dep

FYI @zhangskz, @mkruskal-google, @googleberg


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes

Bzlmod users now get the latest protoc by default. Pin to an older version if desired.

Test plan

  • Covered by existing test cases

@alexeagle alexeagle requested a review from thesayyn May 24, 2024 19:12
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@alexeagle alexeagle merged commit 7d7cc26 into main May 24, 2024
7 checks passed
@alexeagle alexeagle deleted the go branch May 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants