Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor proposed docstring revisions #21

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Conversation

ThomasA
Copy link
Contributor

@ThomasA ThomasA commented Jun 29, 2018

This pull request is part of the review in openjournals/joss-reviews#749

@coveralls
Copy link

coveralls commented Jun 29, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 97cf0b4 on ThomasA:patch-1 into 19f6fdc on astorfi:master.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          25     25           
=====================================
  Hits           25     25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f6fdc...97cf0b4. Read the comment docs.

Copy link
Owner

@astorfi astorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggestions.

I think the description of the feature module should be changed. It looks like there is an extra redundant line break.

@astorfi
Copy link
Owner

astorfi commented Jun 30, 2018

Please update your fork and pull request once again. As I made a lot of changes comparing the fork that you have.

@ThomasA ThomasA force-pushed the patch-1 branch 2 times, most recently from 00d765b to 697dcf7 Compare June 30, 2018 21:31
@ThomasA
Copy link
Contributor Author

ThomasA commented Jun 30, 2018

OK, I rebased the commits and made a few more edits. How about now?

Copy link
Owner

@astorfi astorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. Thanks. However, it may violate the PEP8 for limiting the length of each line.

@astorfi
Copy link
Owner

astorfi commented Jul 1, 2018

You commit has conflict. Please remove this pull request, update your fork and commit again.

@ThomasA
Copy link
Contributor Author

ThomasA commented Jul 3, 2018

I rebased the feature branch - hope it is OK now?

@astorfi astorfi merged commit f5689ef into astorfi:master Jul 3, 2018
@astorfi
Copy link
Owner

astorfi commented Jul 3, 2018

Thank you so much for your modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants