-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor proposed docstring revisions #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 25 25
=====================================
Hits 25 25 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for suggestions.
I think the description of the feature module
should be changed. It looks like there is an extra redundant line break.
Please update your fork and pull request once again. As I made a lot of changes comparing the fork that you have. |
00d765b
to
697dcf7
Compare
OK, I rebased the commits and made a few more edits. How about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better. Thanks. However, it may violate the PEP8 for limiting the length of each line.
You commit has conflict. Please remove this pull request, update your fork and commit again. |
I rebased the feature branch - hope it is OK now? |
Thank you so much for your modifications. |
This pull request is part of the review in openjournals/joss-reviews#749