Return early if Python version check fails #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Jul 5, 2024
dhruvmanila
force-pushed
the
dhruv/python-version-check
branch
from
26efdd3
to
78aac2f
Compare
dhruvmanila
added a commit
that referenced
this pull request
Jul 5, 2024
## Summary I'm not sure why this check was removed looking back at #431, but this validation should be done for both native server and `ruff-lsp`. Both uses a Python script which requires Python 3.7 or later and `ruff` in general also supports 3.7 and later. Without this change, if someone were to use Python 3.6, the extension would give the following error: ``` 2024-07-05 09:26:21.378 [error] Error while trying to find the Ruff binary: Error: Command failed: /Users/dhruv/.pyenv/versions/3.6.15/bin/python /Users/dhruv/work/astral/ruff-vscode/bundled/tool/find_ruff_binary_path.py Traceback (most recent call last): File "/Users/dhruv/work/astral/ruff-vscode/bundled/tool/find_ruff_binary_path.py", line 33, in <module> ruff_binary_path = find_ruff_binary_path() File "/Users/dhruv/work/astral/ruff-vscode/bundled/tool/find_ruff_binary_path.py", line 20, in find_ruff_binary_path elif sys.platform == "darwin" and sys._framework: AttributeError: module 'sys' has no attribute '_framework' ``` ## Test Plan The above error still occurs and the fix for that is in a follow-up PR (#517). Using the below settings: ```json { "ruff.nativeServer":true, "ruff.interpreter": ["/Users/dhruv/.pyenv/versions/3.6.15/bin/python"] } ``` The logs shows that the version isn't supported: ``` 2024-07-05 09:27:38.086 [error] Python version 3.6 is not supported. 2024-07-05 09:27:38.086 [error] Selected python path: /Users/dhruv/.pyenv/versions/3.6.15/bin/python 2024-07-05 09:27:38.086 [error] Supported versions are 3.7 and above. ```
dhruvmanila
force-pushed
the
dhruv/python-version-check-2
branch
from
af924b0
to
e048d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up from #516 and adopted from microsoft/vscode-python-tools-extension-template@723f297.
Test Plan
Same test plan as #516 but validate that the script failure doesn't occur now that we exit early.