-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ruff server
: Defer notebook cell deletion to avoid an error message (…
…#11864) ## Summary Fixes astral-sh/ruff-vscode#496. Cells are no longer removed from the notebook index when a notebook gets updated, but rather when `textDocument/didClose` is called for them. This solves an issue where their premature removal from the notebook cell index would cause their URL to be un-queryable in the `textDocument/didClose` handler. ## Test Plan Create and then delete a notebook cell in VS Code. No error should appear.
- Loading branch information
1 parent
8499abf
commit ffc9852
Showing
2 changed files
with
14 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters