Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce configuration reloading to ruff server #10366

Closed
snowsignal opened this issue Mar 12, 2024 · 0 comments · Fixed by #10404
Closed

Re-introduce configuration reloading to ruff server #10366

snowsignal opened this issue Mar 12, 2024 · 0 comments · Fixed by #10404
Assignees
@snowsignal
Labels
configuration Related to settings and configuration server Related to the LSP server

Comments

@snowsignal
Copy link
Contributor

Summary

File-based configuration reload was removed from #10158 because it was using a file-watcher on the server side, which is actually not recommended by the LSP specification. Instead, we should listen to the didChangeWatchedFiles notification to reload configuration.
@snowsignal snowsignal added the server Related to the LSP server label Mar 12, 2024
@snowsignal snowsignal self-assigned this Mar 12, 2024
@snowsignal snowsignal added the configuration Related to settings and configuration label Mar 12, 2024
This was referenced Mar 14, 2024
Merged
Merged
snowsignal added a commit that referenced this issue Mar 21, 2024
@snowsignal
Automatic configuration reloading for ruff server (#10404)
4f06d59 
## Summary

Fixes #10366.

`ruff server` now registers a file watcher on the client side using the
LSP protocol, and listen for events on configuration files. On such an
event, it reloads the configuration in the 'nearest' workspace to the
file that was changed.

## Test Plan

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snowsignal snowsignal

Labels
configuration Related to settings and configuration server Related to the LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatic configuration reloading for ruff server astral-sh/ruff
1 participant
@snowsignal