Formatter undocumented deviation: long expression wrapped in extra parens and indented

[andersk]

Input, unchanged by Black:

result = (
    f(111111111111111111111111111111111111111111111111111111111111111111111111111111111)
    + 1
).bit_length()

Ruff:

result = (
    (
        f(
            111111111111111111111111111111111111111111111111111111111111111111111111111111111
        )
        + 1
    ).bit_length()
)

[charliermarsh]

Has to do with this being an assignment -- i.e., we don't have this formatting when it's a standalone expression:

(
    f(111111111111111111111111111111111111111111111111111111111111111111111111111111111)
    + 1
).bit_length()

[charliermarsh]

The same problem arises with:

result = (
    f(111111111111111111111111111111111111111111111111111111111111111111111111111111111)
    + 1
)()

Which gets formatted as:

result = (
    (
        f(
            111111111111111111111111111111111111111111111111111111111111111111111111111111111
        )
        + 1
    )()
)

The attribute and call expressions in these two cases (respectively) are returning IfBreaks, because the "head" (value or func) of the expression needs to be parenthesized:

impl NeedsParentheses for ExprAttribute {
    fn needs_parentheses(
        &self,
        _parent: AnyNodeRef,
        context: &PyFormatContext,
    ) -> OptionalParentheses {
        // Checks if there are any own line comments in an attribute chain (a.b.c).
        if CallChainLayout::from_expression(self.into(), context.source())
            == CallChainLayout::Fluent
        {
            OptionalParentheses::Multiline
        } else if context.comments().has_dangling(self) {
            OptionalParentheses::Always
        } else if self.value.is_name_expr() {
            OptionalParentheses::BestFit
        } else {
            self.value.needs_parentheses(self.into(), context)
        }
    }
}