Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated nursery rule group #10172

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Drop deprecated nursery rule group #10172

merged 7 commits into from
Jun 24, 2024

Conversation

T-256
Copy link
Contributor

@T-256 T-256 commented Feb 29, 2024

Summary

Resolves #7992

@MichaReiser MichaReiser added this to the v0.4 milestone Feb 29, 2024
@MichaReiser MichaReiser added the breaking Breaking API change label Feb 29, 2024
@T-256 T-256 marked this pull request as ready for review February 29, 2024 14:52
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10172 will not alter performance

Comparing T-256:drop-nursery (53355b8) with ruff-0.5 (25efb82)

Summary

✅ 30 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb
Copy link
Member

zanieb commented Feb 29, 2024

Thank you! It looks like this didn't make it into v0.3.0 and will need to be considered for v0.4.0 instead

@dhruvmanila dhruvmanila modified the milestones: v0.4.0, v0.5.0 Apr 18, 2024
@MichaReiser MichaReiser changed the base branch from main to ruff-0.5 June 24, 2024 13:08
@MichaReiser MichaReiser merged commit b8c3dfa into astral-sh:ruff-0.5 Jun 24, 2024
20 checks passed
@MichaReiser MichaReiser mentioned this pull request Jun 26, 2024
Merged
MichaReiser pushed a commit that referenced this pull request Jun 27, 2024
@T-256 @MichaReiser
Drop deprecated nursery rule group (#10172)
7d4ffcf 
Co-authored-by: Micha Reiser <micha@reiser.io>
Resolves #7992
MichaReiser pushed a commit that referenced this pull request Jun 27, 2024
@T-256 @MichaReiser
Drop deprecated nursery rule group (#10172)
d6a2cad 
Co-authored-by: Micha Reiser <micha@reiser.io>
Resolves #7992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
breaking Breaking API change
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Remove the "nursery" rule group
4 participants
@T-256 @zanieb @MichaReiser @dhruvmanila