Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the existing ruff_python_trivia::is_python_whitespace function #11844

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Use the existing ruff_python_trivia::is_python_whitespace function #11844

merged 1 commit into from
Jun 12, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

This PR re-uses the ruff_python_trivia::is_python_whitespace in the lexer instead of defining its own. This was mainly to avoid circular dependency which was resolved in #11261.

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jun 12, 2024
@dhruvmanila dhruvmanila enabled auto-merge (squash) June 12, 2024 05:55
@dhruvmanila dhruvmanila merged commit db8f2c2 into main Jun 12, 2024
18 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/whitespace branch June 12, 2024 05:59
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhruvmanila