[red-knot] Extract red_knot_python_semantic crate
#11926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
salsa-9-red_knot_python_semantic
branch
from
377196e
to
05ec870
Compare
AlexWaygood
approved these changes
Jun 18, 2024
|
Oh, I missed some doctests. I'll fix the test failures before merging. |
carljm
approved these changes
Jun 18, 2024
MichaReiser
force-pushed
the
salsa-9-red_knot_python_semantic
branch
from
05ec870
to
9fbb4f7
Compare
MichaReiser
commented
Jun 20, 2024
| @@ -177,15 +179,6 @@ impl std::fmt::Display for ModuleName { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Copy, Clone, Debug, Eq, PartialEq, Hash)] | |||
There was a problem hiding this comment.
I removed this declaration and instead use the one from red_knot_python_semantic to silence cargo shear that the red_knot_python_semantic crate is unused (which is true, but not for long)
MichaReiser
force-pushed
the
salsa-9-red_knot_python_semantic
branch
from
9abe86f
to
4c189af
Compare
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E999 | 1 | 1 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract the red knot code from
ruff_python_semanticand move it into its own crate because we don't expect to share any logic between the two semantic models.Test Plan
cargo build