Remove duplication around is_trivia
functions
#11956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the duplication around
is_trivia
functions.There are two of them in the codebase:
pycodestyle
, it's for newline, indent, dedent, non-logical newline and commentThe
TokenKind::is_trivia
method used (1) but that's not correct in that context. So, this PR introduces a newis_non_logical_token
helper method for thepycodestyle
crate and updates theTokenKind::is_trivia
implementation with (2).This also means we can remove
Token::is_trivia
method and the standalonetoken_source::is_trivia
function and use the one onTokenKind
.Test Plan
cargo insta test