[red-knot]: Implement HasTy for Alias
#11971
Draft
+500
−341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft PR because it requires more documentation and some of the implementation feels errorprone. |
|
MichaReiser
force-pushed
the
alias-has-type
branch
2 times, most recently
from
dad786e
to
86ec41f
Compare
MichaReiser
force-pushed
the
alias-has-type
branch
from
86ec41f
to
19af3c4
Compare
MichaReiser
force-pushed
the
alias-has-type
branch
from
19af3c4
to
cf46aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
HasTyforAliasas a preparation to implement the bad-imports lint rules.The bad-imports lint rule tests if an import resolves to
Unbound. This requires querying querying the type of a specific import-item.The way this is done in this PR is to change
AstIdsto not trackStatements but instead have aDefinitions map, so that we also get IDs for import definitions (and allocate fewer IDs in total).Test Plan
Implemented the
bad-overrideslint rule on top of the new API