Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PEP reference in future_rewritable_type_annotation.rs #11985

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Jun 22, 2024

Summary

Documentation mentions:

PEP 563 enabled the use of a number of convenient type annotations, such as list[str] instead of List[str]

but it meant PEP 585 instead.

PEP 563 is the one defining from __future__ import annotations.

Test Plan

No automated test required, just verify that https://peps.python.org/pep-0585/ is the correct reference.

Copy link

codspeed-hq bot commented Jun 22, 2024

CodSpeed Performance Report

Merging #11985 will degrade performances by 4.81%

Comparing ericbn:patch-1 (4d78032) with main (519a278)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ericbn:patch-1 Change
linter/default-rules[pydantic/types.py] 1.8 ms 1.9 ms -4.81%

@@ -12,7 +12,7 @@ use crate::checkers::ast::Checker;
/// PEP 563.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also been changed or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this reference is correct.

Lots of PEP involved here. :- )

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb added the documentation Improvements or additions to documentation label Jun 23, 2024
@zanieb zanieb merged commit 7156096 into astral-sh:main Jun 23, 2024
19 of 20 checks passed
@ericbn ericbn deleted the patch-1 branch June 23, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants