Fix RUF027 false positives if gettext is imported using an alias

[AlexWaygood]

Noticed this while reviewing if it was ready to be stabilised

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[MichaReiser]

What's exactly the false positive that this PR fixes?

[charliermarsh]

I think it's demonstrated in the fixture: aliasing gettext when importing.

[MichaReiser]

Nice find

[charliermarsh]

The only risk here is: is gettext ever imported from somewhere else, like django.gettext? (I made that up, I have no idea.)

[charliermarsh]

We might want to also check the raw name.

[AlexWaygood]

I think it's demonstrated in the fixture: aliasing gettext when importing.

It's actually not currently; Micha made a good point -- there's a bug in my test :-)

But I'll improve the test so that it does actually fail on main

[AlexWaygood]

The only risk here is: is gettext ever imported from somewhere else, like django.gettext? (I made that up, I have no idea.)

Ah yeah, you're right, that's apparently a thing: https://github.com/django/django/blob/d9bd58c3b8b3e8735d8242c2bb9b09c52ed6171b/django/contrib/flatpages/forms.py#L5

gettext is wild!

[charliermarsh]

I figured there was a reason for this (Chesterton's Fence) hah.