-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flake8-simplify
] Stabilize implicit-else
simplifications in needless-bool
(SIM103
)
#12048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure!
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
SIM103 | 157 | 157 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 49 projects unchanged)
python-poetry/poetry (+0 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- tests/console/commands/test_run.py:113:5: F841 Local variable `tester` is assigned to but never used - tests/console/commands/test_run.py:115:5: F841 Local variable `cmd_script_file` is assigned to but never used
Changes by rule (1 rules affected)
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
F841 | 2 | 0 | 2 | 0 | 0 |
\cc @AlexWaygood - just flagging that there are a lot of ecosystem changes here. |
Summary
See: #10414.
This is a good and intuitive change; we just put it in preview because it expanded scope a bit.